[spirv] Restoring breaks incorrectly dropped #14320
Conversation
When the breaks are lost, literals are enconded/decoded twice, which is wrong. Signed-off-by: Marcos Maronas <marcos.maronas@intel.com>
maarquitos14
changed the title
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers I think this is ready to merge. |
|
@maarquitos14 Can you please check your Github account settings to include your actual mail address in the commit for PRs:
We can only merge after this is fixed. |
This is very weird, I have had several PRs merged in the last year and a half without doing this. Did anything change in Github? |
|
Not that I'm aware of, but maybe this was just missed on previous PRs. The note to gatekeepers to look out for this is relatively new (as in a few months old). |
3 participants
Breaks were lost in 5fd4877, restoring them. When the breaks are lost, literals are enconded/decoded twice, which is wrong.
** This is done in this repo because this piece of code is not present in Khronos repo. **